[PATCH] D41133: [X86] Make the code that creates fmaddsub from build_vector of extracts and inserts functional and add tests.
Simon Pilgrim via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Dec 13 06:43:48 PST 2017
RKSimon added a comment.
Worth adding the fmsubadd tests now (or as a follow up)?
================
Comment at: lib/Target/X86/X86ISelLowering.cpp:29717
SDValue Opnd2;
- if (isFMAddSub(Subtarget, DAG, Opnd0, Opnd1, Opnd2))
+ if (isFMAddSub(Subtarget, DAG, Opnd0, Opnd1, Opnd2, 2))
return DAG.getNode(X86ISD::FMADDSUB, DL, VT, Opnd0, Opnd1, Opnd2);
----------------
Doesn't the ExpectedUses have to be 2/4/8 for xmm/ymm/zmm (double)? and 4/8/16 for float?
https://reviews.llvm.org/D41133
More information about the llvm-commits
mailing list