[PATCH] D41071: [RISCV] implemented assembler pseudo floating point instructions

Alex Bradbury via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 13 05:03:07 PST 2017


asb added a comment.

In https://reviews.llvm.org/D41071#953652, @niosHD wrote:

> Great. I am going to work on the patch which enables aliases by default and updates the tests next. Is it preferred that only the RUN lines are updated to disable aliases in the already existing tests or should the actual content of the tests be updated with aliases?


I think keep the standard test/MC/RISCV/ tests (such as rv32i-valid.s) without aliases, but refresh the CodeGen tests (which should be trivial using update_llc_test_checks.py). The testing of the alias to allow rounding mode not to be explicitly specified should probably move to rvf-aliases-valid.s and rvd-aliases-valid.s

Thanks!


Repository:
  rL LLVM

https://reviews.llvm.org/D41071





More information about the llvm-commits mailing list