[PATCH] D38566: [SimplifyCFG] don't sink common insts too soon (PR34603)

[Hal Finkel via Phabricator via llvm-commits]

hfinkel added inline comments.


================
Comment at: lib/Passes/PassBuilder.cpp:464
+  // GVN has run, so allow more aggressive sinking and select formation.
+  FPM.addPass(SimplifyCFGPass(SimplifyCFGOptions().sinkCommonInsts(true)));
   FPM.addPass(InstCombinePass());
----------------
I don't think that we want this here. This is still during canonicalization. You already have this right after SLP vectorization (we might actually want this right before SLP vectorization - do we SLP vectorize things we'll turn into selects otherwise?). Is it bad if you don't have this here for some test case?


https://reviews.llvm.org/D38566