[PATCH] D41135: EmitFuncArgumentDbgValue: Prefer stack slots over registers for stack arguments

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: test/DebugInfo/COFF/fpo-shrink-wrap.ll:16
 ; ASM:         .cv_fpo_proc    @shrink_wrap_basic at 16 8
-; ASM:         .cv_loc 0 1 3 9                 # t.c:3:9
-; ASM:         movl    %ecx, %eax
----------------
rnk wrote:
> This breaks the test case, though, now it isn't shrink-wrapped. That indicates that DBG_VALUE instructions change the codegen of shrink-wrapping. =(
> 
> We probably just need to skip DBG_VALUE instructions when doing the shrink-wrapping analysis.
Oh! Good catch. That's I bug I should fix regardless!


https://reviews.llvm.org/D41135