[PATCH] D41121: [sanitizer] Introduce a vDSO aware timing function
Kamil Rytarowski via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Dec 12 14:18:41 PST 2017
krytarowski added inline comments.
================
Comment at: lib/sanitizer_common/sanitizer_linux_libcdep.cc:743
+#else
+// Non-Linux & Go always use the syscall.
+u64 MonotonicNanoTime() {
----------------
cryptoad wrote:
> alekseyshl wrote:
> > No action required at the moment, but this comment sounds a bit silly in a file named sanitizer_LINUX_libcdep.cc.
> `// BSDs & go` maybe?
I agree that this naming and OS-specific vs generic parts deserves refactoring. We are now adding here Solaris support in sanitizer_linux_libcdep.cc. D40898
Repository:
rCRT Compiler Runtime
https://reviews.llvm.org/D41121
More information about the llvm-commits
mailing list