[PATCH] D38942: [DAG] Promote ADDCARRY / SUBCARRY

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 12 14:12:17 PST 2017


efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: test/CodeGen/ARM/addsubcarry-promotion.ll:15
+; ARM: movw	r1, #65535
+; ARM: sxth	r2, r2
+; ARM: adc	r0, r2, #0
----------------
rogfer01 wrote:
> This is made redundant by the `tst` below (as it will mask the higher 16 bits) but I presume this has to be fixed elsewhere.
Yes.  (Maybe in SimplifyDemandedBits.)


https://reviews.llvm.org/D38942





More information about the llvm-commits mailing list