[PATCH] D41100: [llvm-objcopy] Add alias and "driver" for llvm-strip
Jake Ehrlich via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Dec 12 10:49:20 PST 2017
jakehehrlich added a comment.
That order of changes sounds pretty reasonable to me. I'll work on breaking it up.
================
Comment at: tools/llvm-objcopy/llvm-objcopy.cpp:165
if (!ToRemove.empty()) {
- RemovePred = [&](const SectionBase &Sec) {
+ RemovePred = [&, this](const SectionBase &Sec) {
return std::find(std::begin(ToRemove), std::end(ToRemove), Sec.Name) !=
----------------
jhenderson wrote:
> Why this change?
ToRemove (and Keep and OnlyKeep) are members of this. This function became a method so that I could change all the variables in it via CopyConfig's members. Adding "this" to the capture list lets me use ToRemove in this function.
Repository:
rL LLVM
https://reviews.llvm.org/D41100
More information about the llvm-commits
mailing list