[PATCH] D40971: [debuginfo-tests] Support moving debuginfo-tests to llvm/projects

[Zachary Turner via llvm-commits]

That’s fine
On Tue, Dec 12, 2017 at 8:13 AM Don Hinton <hintonda at gmail.com> wrote:

> Sure, but I'll need to do it in order:
>
>   D41055
>   D40971 (this patch)
>   D40972
>
> Just wanted to make sure that's okay before starting the process.
>
> thanks...
> don
>
> On Tue, Dec 12, 2017 at 8:05 AM, Zachary Turner <zturner at google.com>
> wrote:
>
>> Lgtm do you want to try committing today?
>>
>> On Sat, Dec 9, 2017 at 9:36 PM Don Hinton via Phabricator <
>> reviews at reviews.llvm.org> wrote:
>>
>>> hintonda added inline comments.
>>>
>>>
>>> ================
>>> Comment at: lit.site.cfg.py.in:25
>>> +# Let the main config do the real work.
>>> +lit_config.load_config(config, "@DEBUGINFO_TESTS_SOURCE_DIR@/
>>> lit.config.py")
>>> ----------------
>>> zturner wrote:
>>> > hintonda wrote:
>>> > > This is how lit find lit.config.py.
>>> > >
>>> > > I'll test the monorepo variant and get back to you.
>>> > Yes, but you need to be able to type `llvm-lit.py
>>> path/to/debuginfo-tests`, and if you do that, lit is going to be looking
>>> specifically for a `lit.cfg.py` and won't find it
>>> Changing the name back to lit.cfg.py was required for the monorepo, but
>>> also required a change to clang, D41055, which needs to land first -- hope
>>> I set the dependency correctly.
>>>
>>>
>>> https://reviews.llvm.org/D40971
>>>
>>>
>>>
>>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171212/da23a2b0/attachment.html>