[PATCH] D40879: [X86][I86, I186, I286, I386, I486, Pentium]: Adding full coverage of MC encoding for the I86, I186, I286, I386, I486 and Pentium isa sets.<NFC>

[Alex Bradbury via Phabricator via llvm-commits]

asb added a comment.

In https://reviews.llvm.org/D40879#952166, @gadi.haber wrote:

> Interesting. 
>  I can get/check the encoded bytes this way but what about checking the assembly instruction representation? e.g. checking the assembly instruction : "imull $0, %r13d, %r13d"?


In the example I pasted I actually only check the assembly instruction in the objdump output.

You'd rewrite your test to do this:

  // RUN: llvm-mc -triple i386-unknown-unknown --show-encoding %s | FileCheck -check-prefixes=CHECK,CHECK-INST %s
  // RUN: llvm-mc -triple i386-unknown-unknown -filetype=obj < %s | llvm-objdump -d - | FileCheck -check-prefix=CHECK-INST %s
  
  // CHECK-INST: enter $0, $0 
  // CHECK: encoding: [0xc8,0x00,0x00,0x00]       
  enter $0, $0 
  
  // CHECK-INST: insb %dx, %es:(%edi) 
  // CHECK: encoding: [0x6c]       
  insb %dx, %es:(%edi) 

The CHECK: line is ignored by the objdump RUN line, and CHECK-INST is checked for both.


Repository:
  rL LLVM

https://reviews.llvm.org/D40879