[PATCH] D40524: Handle the case of live 16-bit subregisters in X86FixupBWInsts

Andrei Elovikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 12 00:33:05 PST 2017


a.elovikov added a comment.

> In https://reviews.llvm.org/D40524#951832, @andrew.w.kaylor wrote:
>  I'm not terribly familiar with MIR as it appears in a test like this, but I can't see any reason that your proposed testcase would be invalid. I do think it's extremely unlikely to arise in actual generated Machine IR, since we hardly ever use the 8-bit high registers. What I'd like to do is commit the change from this review as is, and file a new Bugzilla report to track the 8bit_hi issue.  Does that sound reasonable to you?

Yes, these are two separate issues, IMO.


https://reviews.llvm.org/D40524





More information about the llvm-commits mailing list