[PATCH] D40849: CodeGen: support an extension to pass linker options on ELF

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

Yeah. As long as you are limiting the options that you can use in the embedded option string small and define them clearly, I'm basically fine with the basic idea of the embedded option itself.

As to the file format, does this patch produce a single string containing multiple options? If so, please consider emitting one string for each command line option. In COFF, an object file has only one string containing all embedded options, and parsing that string using the exact same rule as the shell (in this case DOS command prompt) would use is unnecessarily complicated and error-prone. We shouldn't repeat the same mistake in ELF.


Repository:
  rL LLVM

https://reviews.llvm.org/D40849