[PATCH] D40699: Split IndirectBr critical edges before PGO gen/use passes.

Hiroshi Yamauchi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 11 14:53:19 PST 2017


yamauchi marked 2 inline comments as done.
yamauchi added inline comments.


================
Comment at: lib/Transforms/Instrumentation/PGOInstrumentation.cpp:544
+            !E->InMST && E->IsCritical && E->DestBB)
+          IndirectBrTargets.insert(const_cast<BasicBlock *>(E->DestBB));
+      }
----------------
davidxl wrote:
> It seems cleaner to move the IndirectBrTargets collection inside MST's buildEdges method.
This comment doesn't apply any more.


https://reviews.llvm.org/D40699





More information about the llvm-commits mailing list