[lld] r320286 - PPC32: Support R_PPC_PLTREL32 in static mode.

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 11 14:43:14 PST 2017


vit9696 <vit9696 at avp.su> writes:

> Hello,
>
> Thanks for pointing out an interesting specialty regarding lld optimisations. I indeed was unaware of fromPlt, since I only looked into PPC-specific code. I have just checked and can confirm that R_PLT_PC also works fine thanks to that feature.
>
> In this case the code could be even cleaner, and one should be safe to replace R_PC by R_PLT_PC. I do not mind submitting a patch for a review that will replace one thing by the other, but since it is an obvious one-line change (which will somebody have to commit it for me anyway), could you please apply the change right away? I attached the diff to the message.

Oops. I missed the attachment somehow.

In any case, I don't think we need a special comment for returning
R_PLT_PC since that is the correct value.

I changed it in r320430.

Thanks,
Rafael


More information about the llvm-commits mailing list