[PATCH] D41041: [ELF] Don't set the executable bit for relocatable or shared files
Rui Ueyama via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Dec 11 14:32:21 PST 2017
ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.
LGTM with this fix.
================
Comment at: ELF/Writer.cpp:1837
+ unsigned Flags = 0;
+ if (!Config->Relocatable && !Config->Shared)
+ Flags = FileOutputBuffer::F_executable;
----------------
Please remove `!Config->Shared` as other linkers set X bit to shared libraries.
Repository:
rLLD LLVM Linker
https://reviews.llvm.org/D41041
More information about the llvm-commits
mailing list