[PATCH] D41057: Avoid a gnu readelf warning

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 11 11:23:50 PST 2017


Rui Ueyama via Phabricator <reviews at reviews.llvm.org> writes:

> ruiu added inline comments.
>
>
> ================
> Comment at: ELF/SyntheticSections.cpp:1233
> +  if (this == InX::RelaPlt) {
> +    Info = InX::GotPlt->getParent()->SectionIndex;
> +    getParent()->Info = Info;
> ----------------
> grimar wrote:
>> emaste wrote:
>> > Why `.got.plt` and not `.plt`?
>> Do we really want to care about readelf warnings about something that is not in ELF spec (I assume it is not) ?  While it is not a error... may be we can just ignore it ?
> I think I feel the same as George. Is this an issue?
>
> Can you always set or always not set `Info`?

That would set it for .rela.dyn which would be wrong as it relocates
content that is in multiple sections.

Cheers,
Rafael


More information about the llvm-commits mailing list