[PATCH] D40964: [LLD][ELF] Move SHF_LINK_ORDER processing earlier in Writer.cpp [NFC]
Rafael Avila de Espindola via llvm-commits
llvm-commits at lists.llvm.org
Mon Dec 11 11:06:36 PST 2017
Peter Smith via Phabricator <reviews at reviews.llvm.org> writes:
> +template <class ELFT> void Writer<ELFT>::resolveShfLinkOrder() {
> + // Link order may be distributed across several InputSectionDescriptions
> + // but sort must consider them all at once.
Move the comment after the continue.
> + for (OutputSection *Sec : OutputSections) {
> + if (!(Sec->Flags & SHF_LINK_ORDER))
> + continue;
Here.
LGTM with that.
Thanks,
Rafael
More information about the llvm-commits
mailing list