[PATCH] D40699: Split IndirectBr critical edges before PGO gen/use passes.

[Hiroshi Yamauchi via Phabricator via llvm-commits]

yamauchi added inline comments.


================
Comment at: lib/Transforms/Instrumentation/PGOInstrumentation.cpp:548
+        SplitIndirectBrCriticalEdges(F, &IndirectBrTargets, BPI, BFI);
+        MST = CFGMST<Edge, BBInfo>(&F, BPI, BFI);
+      }
----------------
davidxl wrote:
> There seems no guarantee that the non-split indirectBR critical edges will be be in MST when cfgmst is recomputed. 
Good point. I'll go back to splitting all indirectBR critical edges before computing the MST (the previous diff).


https://reviews.llvm.org/D40699