[PATCH] D41057: Avoid a gnu readelf warning

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 11 10:47:02 PST 2017


George Rimar via Phabricator <reviews at reviews.llvm.org> writes:

> grimar added inline comments.
>
>
> ================
> Comment at: ELF/SyntheticSections.cpp:1233
> +  if (this == InX::RelaPlt) {
> +    Info = InX::GotPlt->getParent()->SectionIndex;
> +    getParent()->Info = Info;
> ----------------
> emaste wrote:
>> Why `.got.plt` and not `.plt`?
> Do we really want to care about readelf warnings about something that is not in ELF spec (I assume it is not) ?  While it is not a error... may be we can just ignore it ?

Maybe. I guess I should at least report a bug on gnu readelf and see
what they say.

Cheers,
Rafael


More information about the llvm-commits mailing list