[PATCH] D41061: Updated llvm-objdump to display local relocations in Mach-O binaries

[Kevin Enderby via Phabricator via llvm-commits]

enderby added inline comments.


================
Comment at: tools/llvm-objdump/MachODump.cpp:698
+              llvm::object::DataRefImpl DRI;
+              DRI.d.a = r_symbolnum-1;
+              if (DRI.d.a < O->section_end()->getRawDataRefImpl().d.a) {
----------------
 I think you might need a test that r_symbolnum is zero first and output "(?,?)" in that case before you subtract one.  Not sure that case will call out with the logic below.  See the change in r317373.


https://reviews.llvm.org/D41061