[PATCH] D40960: Fix for bug PR35549 - [X86] Repeated schedule comments
Simon Pilgrim via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Dec 11 09:34:12 PST 2017
RKSimon added inline comments.
================
Comment at: lib/Target/X86/X86MCInstLower.cpp:2007
MCInstLowering.Lower(MI, TmpInst);
+ TmpInst.setFlags(MI->getFlags());
----------------
avt77 wrote:
> RKSimon wrote:
> > Won't this copy other flags as well? Is that safe?
> Yes, that's exactly what we need here.
So is this a separate issue that needs tests and possibly a separate preliminary patch? Are you missing prefix flags data because of this?
https://reviews.llvm.org/D40960
More information about the llvm-commits
mailing list