[PATCH] D41052: [LLD] [MinGW] Don't pass -dynamicbase:no by default for arm/arm64

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 11 09:18:55 PST 2017


ruiu added inline comments.


================
Comment at: MinGW/Driver.cpp:162-164
+  if (Args.getLastArgValue(OPT_m) != "thumb2pe" &&
+      Args.getLastArgValue(OPT_m) != "arm64pe")
+    Add(Args.hasArg(OPT_dynamicbase) ? "-dynamicbase" : "-dynamicbase:no");
----------------
If a user passes `-dynamicbase` to the MinGW driver, we should just pass it through to the COFF driver, no? Ignoring `-dynamicbase` if arm/arm64 seems odd to me.


https://reviews.llvm.org/D41052





More information about the llvm-commits mailing list