[PATCH] D40970: [ThinLTO] Remove unused (?) code from thinLTOInternalizeModule
Teresa Johnson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Dec 11 08:50:14 PST 2017
tejohnson accepted this revision.
tejohnson added a comment.
In https://reviews.llvm.org/D40970#951028, @evgeny777 wrote:
> @tejohnson Any comments or objections?
This should be fine - if we weren't marking these correctly in the summaries before the thin link we would be computing dead symbols incorrectly and have bigger problems.
For gold and lld this information is computed by and accessed via the IRSymtab. I'm not sure / can't remember how this is handled via ld64 and the legacy LTO API, but like I said, thin link dead stripping would overall not work if we didn't mark these as exported.
Repository:
rL LLVM
https://reviews.llvm.org/D40970
More information about the llvm-commits
mailing list