[PATCH] D40975: [LangRef] Reflect the changes in the TBAA info format

Hal Finkel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 11 05:47:20 PST 2017


hfinkel added a comment.

I think that we're on the same page. I'll also start reviewing the other patches.



================
Comment at: docs/LangRef.rst:4592
+be a type descriptor or the TBAA root.  Via this parent relation, types
+within a TBAA root form a tree.  Types with different roots have an unknown
+aliasing relationship, and LLVM conservatively infers ``MayAlias`` between
----------------
Types with different roots have an unknown aliasing relationship, and LLVM conservatively infers ``MayAlias`` between them. -> TBAA metadata provides no aliasing information about types with different roots.


================
Comment at: docs/LangRef.rst:4601
+otherwise they are identical.  For example, two C structures of the same layout
+can be differentiated with identifier nodes containing their tag names.
+
----------------
identifier nodes -> metadata strings


================
Comment at: docs/LangRef.rst:4635
+
+ * the base type of one access is the type of a direct or indirect field of
+   the other base type and the ranges of accessed bytes within that field type
----------------
You've not defined direct or indirect field anywhere. Please do.


================
Comment at: docs/LangRef.rst:4670
     }
 
+the type descriptor graph is:
----------------
Please also add a union to this example.


Repository:
  rL LLVM

https://reviews.llvm.org/D40975





More information about the llvm-commits mailing list