[PATCH] D40935: Hardware-assisted AddressSanitizer (compiler-rt)

[Evgenii Stepanov via Phabricator via llvm-commits]

eugenis added inline comments.


================
Comment at: compiler-rt/lib/hwasan/hwasan.cc:60
+
+int hwasan_report_count = 0;
+
----------------
kcc wrote:
> seems to be unused (nothings sets it to non zero), please remove. 
I've implemented halt_on_error=0


================
Comment at: compiler-rt/lib/hwasan/hwasan.cc:99
+
+#if HWASAN_CONTAINS_UBSAN
+  __ubsan::Flags *uf = __ubsan::flags();
----------------
kcc wrote:
> can we not have any of these #ifdefs? 
> 
don't we want hwasan + ubsan and hwasan + lsan?


================
Comment at: compiler-rt/lib/hwasan/hwasan.cc:194
+  DisableCoreDumperIfNecessary();
+  if (StackSizeIsUnlimited()) {
+    VPrintf(1, "Unlimited stack, doing reexec\n");
----------------
kcc wrote:
> do we need this? 
> For asan we did, but probably not for hwasan
we don't


https://reviews.llvm.org/D40935