[PATCH] D40944: [profile] Enable on Solaris

[Vedant Kumar via Phabricator via llvm-commits]

vsk added inline comments.


================
Comment at: lib/profile/GCDAProfiling.c:39
 #define O_BINARY 0
 #endif
 #endif
----------------
ro wrote:
> vsk wrote:
> > Why not migrate O_BINARY to the common header as well?
> Looking closer, I see that both MAP_FILE and O_BINARY
> are problematic: InstrProfilingPort.h and/or InstrProfiling.h
> are included before system headers, but such fallback definitions
> need to come after those had a chance to provide the real
> definitions.  To fix this, either the system header includes
> need to be moved to the InstProfiling{Port,}.h files or those
> need to be included after system headers.  WDYT?
Moving the InstrProfiling*.h imports after the system header imports sgtm, but please add a short comment there explaining why we're relying on that sort of textual #include (it goes against typical llvm practice).


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D40944