[PATCH] D40970: [ThinLTO] Remove unused (?) code from thinLTOInternalizeModule

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added inline comments.


================
Comment at: lib/Transforms/IPO/FunctionImport.cpp:647
-  // the current module.
-  StringSet<> AsmUndefinedRefs;
-  ModuleSymbolTable::CollectAsmSymbols(
----------------
evgeny777 wrote:
> The thinLTOInternalizeModule running in separate thread for each module being LTO'ed
> So if we found some undefined symbol, which defined in another module what we can do now? That other 
> module might have already been internalized (or is being internalized at the same moment on another CPU core).
> 
The comment below says "Can't be internalized if referenced in inline asm", which isn't about cross-module reference. The weird part is that the comment above is supposed to collect "the list of symbols that are not defined in the current module", which shouldn't be possibly interfering with the symbol considered for internalization.



Repository:
  rL LLVM

https://reviews.llvm.org/D40970