[PATCH] D40962: [ELF] When a relocation is out of range print the value and the range

Alexander Richardson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 8 05:37:35 PST 2017


arichardson added inline comments.


================
Comment at: ELF/Target.h:150
+  error(getErrorLocation(Loc) + "relocation " + lld::toString(Type) +
+        " out of range: requested value " + V + " is not in [" + Twine(Min) +
+        ", " + Twine(Max) + "]");
----------------
grimar wrote:
> nit: I would shorten this:
> relocation R_386_PC16 out of range: 65536 is not in [-65536, 65535]
> It is the matter of taste though.
Sounds good, I'll change if it to that if Rui also agrees.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D40962





More information about the llvm-commits mailing list