[PATCH] D40885: [NFC] Refactor SafepointIRVerifier
Daniil Suchkov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Dec 8 04:02:43 PST 2017
DaniilSuchkov added inline comments.
================
Comment at: lib/IR/SafepointIRVerifier.cpp:241
+class GCPtrTracker {
+ const Function &F;
+ const DominatorTree &DT;
----------------
mkazantsev wrote:
> Do you really need this field? It is only used in `verifyFunction`, why not just pass the function into it as parameter?
We need `F` both in constructor and `verifyFunction` and it must be the same value so it's better leave it as a field.
Though `const DominatorTree &DT` isn't required to be field so it'll be removed.
https://reviews.llvm.org/D40885
More information about the llvm-commits
mailing list