[PATCH] D40725: Wasm entrypoint changes #3 (add --no-entry argument to LLD)

[Nicholas Wilson via Phabricator via llvm-commits]

ncw added inline comments.


================
Comment at: wasm/Driver.cpp:328
+    if (!Symtab->find(Config->Entry)->isDefined())
+      error("entry point not found: " + Config->Entry);
   }
----------------
sbc100 wrote:
> It looks like this change also means that --allow-undefined no longer applies to '_start'.   I'm not necessarily against that but is there a reason for this change?   
Ah good spot, I should have included that tweak in the `--undefined` review.

There is a reason: a) consistency with what we decided for `--undefined`, where `--allow-undefined` also doesn't apply, and b) it just makes no sense at all to import the entrypoint - if `_start` isn't found from libc. I can't imagine a single developer would want it to be silently added as an import instead!


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D40725