[PATCH] D40985: [AArch64] Add Exynos to host detection

Kristof Beyls via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 8 00:03:08 PST 2017


kristof.beyls accepted this revision.
kristof.beyls added a comment.
This revision is now accepted and ready to land.

LGTM modulo the one nitpick for which I'm not sure if it is needed.



================
Comment at: llvm/lib/Support/Host.cpp:237-241
+    switch (Exynos) {
+    default:
+      // Default to Exynos M1.
+
+    case 0x01001:
----------------
I guess you may need to use LLVM_FALLTHROUGH here to silence a warning with some compilers?


https://reviews.llvm.org/D40985





More information about the llvm-commits mailing list