[PATCH] D40978: TableGen: Allow setting SDNodeProperties on intrinsics

[Matt Arsenault via Phabricator via llvm-commits]

arsenm created this revision.
Herald added subscribers: mgorny, wdng.

Allows preserving MachineMemOperands on intrinsics
through selection. For reasons I don't understand, this
is a static property of the pattern and the selector
deliberately goes out of its way to drop if not present.

      

Intrinsics already inherit from SDPatternOperator allowing
them to be used directly in instruction patterns. SDPatternOperator
has a list of SDNodeProperty, but you currently can't set them on
the intrinsic. Without SDNPMemOperand, when the node is selected
any memory operands are always dropped. Allowing setting this
on the intrinsics avoids needing to introduce another equivalent
target node just to have SDNPMemOperand set.


https://reviews.llvm.org/D40978

Files:
  include/llvm/CodeGen/SDNodeProperties.td
  include/llvm/IR/Intrinsics.td
  include/llvm/Target/TargetSelectionDAG.td
  utils/TableGen/CMakeLists.txt
  utils/TableGen/CodeGenDAGPatterns.cpp
  utils/TableGen/CodeGenDAGPatterns.h
  utils/TableGen/CodeGenIntrinsics.h
  utils/TableGen/CodeGenTarget.cpp
  utils/TableGen/CodeGenTarget.h
  utils/TableGen/SDNodeProperties.cpp
  utils/TableGen/SDNodeProperties.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D40978.126013.patch
Type: text/x-patch
Size: 15022 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171207/8a3bbda8/attachment.bin>