[PATCH] D40973: [LV] Remove unnecessary DoExtraAnalysis guard (silent bug)
Florian Hahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Dec 7 11:28:17 PST 2017
fhahn added a comment.
This seems like a bug indeed! Could you add a test case without a preheader, to make sure we catch this regression in the future?
================
Comment at: lib/Transforms/Vectorize/LoopVectorize.cpp:5000
bool Result = true;
-
bool DoExtraAnalysis = ORE->allowExtraAnalysis(DEBUG_TYPE);
----------------
unrelated whitespace change?
================
Comment at: lib/Transforms/Vectorize/LoopVectorize.cpp:5008
<< "loop control flow is not understood by vectorizer");
- if (DoExtraAnalysis)
Result = false;
----------------
Could you check if this has the correct indentation? It looks off in the Phabricator web view.
https://reviews.llvm.org/D40973
More information about the llvm-commits
mailing list