[PATCH] D40962: [ELF] When a relocation is out of range print the value and the range
Rui Ueyama via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Dec 7 11:21:44 PST 2017
ruiu added inline comments.
================
Comment at: ELF/Target.h:147
+static inline void relocationRangeError(uint8_t *Loc, RelType Type,
+ const Twine &V, int64_t Min,
----------------
In general a function name should be a verb, so how about reportRangeError?
================
Comment at: ELF/Target.h:151-152
+ error(getErrorLocation(Loc) + "relocation " + lld::toString(Type) +
+ " out of range: requested value " + V + " is not in [" + Twine(Min) +
+ "," + Twine(Max) + "]");
+}
----------------
I think the range is half-open, so you should use [) instead of [].
Please add a space character after the comma.
Repository:
rLLD LLVM Linker
https://reviews.llvm.org/D40962
More information about the llvm-commits
mailing list