[PATCH] D38406: [dump] Make LLVM_ENABLE_DUMP independent, and move to llvm-config.h

Thu Dec 7 09:46:26 PST 2017

bogner added inline comments.

================
Comment at: CMakeLists.txt:396-398
-if( LLVM_ENABLE_ASSERTIONS )
-  set(LLVM_ENABLE_DUMP ON)
-endif()
----------------
hintonda wrote:
> bogner wrote:
> > Since everything checks both currently it doesn't actually have an effect, but I think we should leave this in place for now. It more accurately reflects our intent.
> I added this in D38306 based on the assumption that we could remove the NDEBUG test and just use the LLVM_ENABLE_DUMP test for dump definitions -- and other related functions.
> 
> However, that turned out to be a bad idea.  So I think this should removed.  Especially since it leaves the reader with the impression that you need to do it, which is false.
> 
> The only good thing about it is that it doesn't update the cache, so it's wrong but innocuous.
Okay, that makes sense.

https://reviews.llvm.org/D38406