[PATCH] D40390: [InstCombine] Don't crash on out of bounds index in the insertelement
Phabricator via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Dec 7 07:01:26 PST 2017
This revision was automatically updated to reflect the committed changes.
Closed by commit rL320049: [InstCombine] Don't crash on out of bounds index in the insertelement (authored by igor.laevsky).
Changed prior to commit:
https://reviews.llvm.org/D40390?vs=125321&id=125950#toc
Repository:
rL LLVM
https://reviews.llvm.org/D40390
Files:
llvm/trunk/lib/Transforms/InstCombine/InstCombineVectorOps.cpp
llvm/trunk/test/Transforms/InstCombine/out-of-bounds-indexes.ll
llvm/trunk/test/Transforms/InstCombine/vector_insertelt_shuffle.ll
Index: llvm/trunk/test/Transforms/InstCombine/vector_insertelt_shuffle.ll
===================================================================
--- llvm/trunk/test/Transforms/InstCombine/vector_insertelt_shuffle.ll
+++ llvm/trunk/test/Transforms/InstCombine/vector_insertelt_shuffle.ll
@@ -54,10 +54,10 @@
ret <4 x float> %ins6
}
+; Out of bounds index folds to undef
define <4 x float> @bazzz(<4 x float> %x) {
; CHECK-LABEL: @bazzz(
-; CHECK-NEXT: [[INS2:%.*]] = insertelement <4 x float> %x, float 2.000000e+00, i32 2
-; CHECK-NEXT: ret <4 x float> [[INS2]]
+; CHECK-NEXT: ret <4 x float> <float undef, float undef, float 2.000000e+00, float undef>
;
%ins1 = insertelement<4 x float> %x, float 1.0, i32 5
%ins2 = insertelement<4 x float> %ins1, float 2.0, i32 2
Index: llvm/trunk/test/Transforms/InstCombine/out-of-bounds-indexes.ll
===================================================================
--- llvm/trunk/test/Transforms/InstCombine/out-of-bounds-indexes.ll
+++ llvm/trunk/test/Transforms/InstCombine/out-of-bounds-indexes.ll
@@ -31,3 +31,11 @@
}
declare void @llvm.assume(i1)
+
+define <4 x double> @inselt_bad_index(<4 x double> %a) {
+; CHECK-LABEL: @inselt_bad_index(
+; CHECK-NEXT: ret <4 x double> undef
+;
+ %I = insertelement <4 x double> %a, double 0.0, i64 4294967296
+ ret <4 x double> %I
+}
Index: llvm/trunk/lib/Transforms/InstCombine/InstCombineVectorOps.cpp
===================================================================
--- llvm/trunk/lib/Transforms/InstCombine/InstCombineVectorOps.cpp
+++ llvm/trunk/lib/Transforms/InstCombine/InstCombineVectorOps.cpp
@@ -781,6 +781,10 @@
Value *ScalarOp = IE.getOperand(1);
Value *IdxOp = IE.getOperand(2);
+ if (auto *V = SimplifyInsertElementInst(
+ VecOp, ScalarOp, IdxOp, SQ.getWithInstruction(&IE)))
+ return replaceInstUsesWith(IE, V);
+
// Inserting an undef or into an undefined place, remove this.
if (isa<UndefValue>(ScalarOp) || isa<UndefValue>(IdxOp))
replaceInstUsesWith(IE, VecOp);
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D40390.125950.patch
Type: text/x-patch
Size: 2033 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171207/ff682ea3/attachment.bin>
More information about the llvm-commits
mailing list