[PATCH] D37631: [libFuzzer] Support using libc++

[Petr Hosek via Phabricator via llvm-commits]

phosek marked an inline comment as done.
phosek added inline comments.


================
Comment at: lib/fuzzer/CMakeLists.txt:81
 
+if(CMAKE_CXX_COMPILER_ID MATCHES Clang AND COMPILER_RT_HAS_LIBCXX_SOURCES)
+  foreach(arch ${FUZZER_SUPPORTED_ARCH})
----------------
vitalybuka wrote:
> why do we need check for Clang here and below?
Remove, I've reworked the patch to explicitly include libc++ headers so this now works with GCC as well.


================
Comment at: test/fuzzer/lit.cfg:84
+
+config.substitutions.append(('%libcxx_c_compiler',
+      generate_compiler_cmd(is_cpp=False, libcxx=True, fuzzer_enabled=True)
----------------
vitalybuka wrote:
> Is any patch with tests which shows how this substitutions are going to be used?
> I'd probably keep this part of change with actual tests using this.
This is no longer used so removed.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D37631