[PATCH] D38406: [dump] Make LLVM_ENABLE_DUMP independent, and move to llvm-config.h

Justin Bogner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 6 22:21:20 PST 2017


bogner accepted this revision.
bogner added a comment.

At this point this is strictly better. Let's make this change and figure out where to go from here in tree.



================
Comment at: CMakeLists.txt:396-398
-if( LLVM_ENABLE_ASSERTIONS )
-  set(LLVM_ENABLE_DUMP ON)
-endif()
----------------
Since everything checks both currently it doesn't actually have an effect, but I think we should leave this in place for now. It more accurately reflects our intent.


https://reviews.llvm.org/D38406





More information about the llvm-commits mailing list