[PATCH] D38406: [dump] Remove NDEBUG from test to enable dump methods [NFC]

Matthias Braun via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 6 16:39:14 PST 2017


MatzeB added a comment.

Let's wait a bit to see if this is fine with people. It would probably be also nice to add the `set(LLVM_ENABLE_DUMP OFF CACHE BOOL "")` line to the varous caches in clang/cmake/caches that build llvm in release build types.



================
Comment at: CMakeLists.txt:388
 
-option(LLVM_ENABLE_DUMP "Enable dump functions in release builds" OFF)
+option(LLVM_ENABLE_DUMP "Enable dump functions in release builds" ON)
 
----------------
Should also change the description to "Enable dump functions" (without the "in release builds") now.


https://reviews.llvm.org/D38406





More information about the llvm-commits mailing list