[PATCH] D38406: [dump] Remove NDEBUG from test to enable dump methods [NFC]

Matthias Braun via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 6 16:08:49 PST 2017


MatzeB added a comment.

> (via either a -D or -I options), but that defeats the purpose of

moving LLVM_ENABLE_DUMP to a header file in the first place -- it was
originally set via a cmake add_definitions directive.

It doesn't really defeat that purpose: From the point of view of an external llvm user no flags need to be set at all! (Assuming someone prepared a nice package where llvm-config.h just lives next to all the other headers). The complexity of creating multiple llvm-config.h files in different directories and adding different -I to have each config include their specific directory is contained within llvms build system.


https://reviews.llvm.org/D38406





More information about the llvm-commits mailing list