[PATCH] D40728: [CallSiteSplitting] Refactor creating callsites.

[Jun Bum Lim via Phabricator via llvm-commits]

junbuml added a comment.

LGTM.  However, I believe we need more test cases including eq_eq_eq_taken in order to prevent any future change from breaking this pass.  It will be also good to add a test case where the same argument is used multiple ICMPs.



================
Comment at: test/Transforms/CallSiteSplitting/callsite-split-or-phi.ll:354
+;CHECK: ret i32 %[[MERGED]]
+define i32 @test_eq_eq_eq_untaken(i32* %a, i32 %v, i32 %p) {
+Header:
----------------
In order to prevent any future change from breaking this pass, I believe we need more test cases including eq_eq_eq_taken. It will be also good to add a test case where the same argument is used multiple ICMPs. 


https://reviews.llvm.org/D40728