[PATCH] D40747: [ThinLTO] Enable importing of aliases as copy of aliasee

[David Blaikie via llvm-commits]

On Wed, Dec 6, 2017 at 12:53 PM Teresa Johnson via Phabricator <
reviews at reviews.llvm.org> wrote:

> tejohnson added a comment.
>
> In https://reviews.llvm.org/D40747#943859, @dblaikie wrote:
>
> > Just a quick note:
> >
> > Could you check what the debug info looks like for an imported alias
> that is inlined, and one that isn't inlined?
> >
> > Specifically my concern is over whether or not this causes a second CU
> to be created - currentyl we're threading a needle to avoid fixing/updating
> GDB by not needing multiple CUs per DWO file due to importing cross-CU
> inlining into the calling CU, etc.
> >
> > Can talk more offline or through this thread.
>
>
> On-list update: David and I discussing offline. But essentially the same
> thing happens to debug info when we import an alias vs a normal function.
> David is looking at whether that is correct, but we are consistent. This is
> expected since the imported aliases (copies of aliasee) are
> available_externally just like other imported functions.
>

Yep - if it's the same implementation (available_externally)/observed
behavior, that covers my concerns here.

Thanks for the repro that maybe this isn't quite doing the right thing in
general & I'll look into that, but nothing to worry about for this specific
change either way.


>
>
> https://reviews.llvm.org/D40747
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171206/73e52eeb/attachment.html>