[PATCH] D40617: [LV] Interleaved access vectorization: fix computing new alias info

[Michael Kuperstein via Phabricator via llvm-commits]

mkuper accepted this revision.
mkuper added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lib/Transforms/Vectorize/LoopVectorize.cpp:952
+                   [](std::pair<int, Instruction *> p) { return p.second; });
+    propagateMetadata(NewInst, VL);
+  }
----------------
anemet wrote:
> mkuper wrote:
> > InnerLoopVectorizer::addMetadata() also calls addNewMetadata(), while this doesn't.
> > Is that intentional?
> Yes, it is intentional.  addNewMetadata adds noalias metadata based on the inserted memchecks.  We need a way to aggregate that information from several accesses as well.
> 
> I can add a FIXME that we don't propagate this information currently.  This is conservatively correct.
The FIXME would probably be good.


https://reviews.llvm.org/D40617