[PATCH] D40559: Wasm entrypoint changes #2 (export entrypoint in "start" section) APPLY AFTER D40724

[Sam Clegg via Phabricator via llvm-commits]

sbc100 added a comment.

I'd rather not change the behaviour of --entry since its a flag that is in common usage.    I'd also rather not default --no-entry since that means that by default nothing will get pulled into the link (i.e. all users will need explicit --entry and/or --undefined otherwise nothing will be linked).

I don't mind adding code to support writing the start section, but since it is (currently) of very limited use I think we should not enable it by default.   How about putting it behing a new flag (i.e. --start=foo).    Even that much I think is a little controversial since we don't know if there will be any users of this flag.

Sorry to be negative about this change.  I do think in the future we may have more use (or even default use) of the start section, but thats later down the road.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D40559