[PATCH] D40900: [Sanitizers, test] Fix sanitizer tests on Solaris (PR 33274)

[Kamil Rytarowski via Phabricator via llvm-commits]

krytarowski added inline comments.


================
Comment at: test/asan/TestCases/Posix/ioctl.cc:13
 
+#if defined(__sun__) && defined(__svr4__)
+#include <sys/filio.h>
----------------
Do we need to check for `__svr4__`? Are there other alive SunOS systems?


================
Comment at: test/asan/TestCases/alloca_loop_unpoisoning.cc:17
+#elif defined(__FreeBSD__) || defined(__NetBSD__)
+#include <stdlib.h>
+#else
----------------
<stdlib.h> is included above.


================
Comment at: test/asan/TestCases/alloca_vla_interact.cc:17
+#elif defined(__FreeBSD__) || defined(__NetBSD__)
+#include <stdlib.h>
+#else
----------------
<stdlib.h> is already included


================
Comment at: test/asan/TestCases/debug_double_free.cc:20
+#elif defined(__sun__) && defined(__svr4__)
+# define PTR_FMT "0x%p"
 #else
----------------
Is there an option to use `%#p`?


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D40900