[PATCH] D36704: [CodeGen] Improve the consistency of instruction fusion

[Florian Hahn via Phabricator via llvm-commits]

fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.

Thanks Evandro. I think this looks good to me now. I still think it's unfortunate that we basically duplicate the loop to add artificial dependences, but I don't see a way to share the code without making it more complicated than it is now. Please wait a bit with committing, to give Matthias a chance to voice additional concerns.



================
Comment at: llvm/lib/CodeGen/MacroFusion.cpp:94
+      SUnit *SU = SI.getSUnit();
+      if (SI.isWeak() || isHazard(SI) ||
+          &FirstSU == SU || FirstSU.isSucc(SU))
----------------
Hard to tell in Phabricator, could you check if that could go on the previous line?


Repository:
  rL LLVM

https://reviews.llvm.org/D36704