[PATCH] D40725: Wasm entrypoint changes #3 (add --no-entry argument to LLD) APPLY AFTER D40559

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: wasm/Config.h:38
   uint32_t ZStackSize;
-  llvm::StringRef Entry;
+  llvm::Optional<llvm::StringRef> Entry;
   llvm::StringRef OutputFile;
----------------
sbc100 wrote:
> I still think its simpler just to use empty string to mean no entry and continue to assume that empty strings cannot be symbols.   I'm don't feel super strongly about it though.  I guess maybe we should agree to spec in Linking.md that symbols cannot be empty strings?
I prefer empty string too. It is consistent with other lld ports.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D40725