[PATCH] D40766: Handle NetBSD symbol renaming in msan_interceptors.cc

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka accepted this revision.
vitalybuka added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lib/msan/msan_interceptors.cc:38
+#if SANITIZER_NETBSD
+#define gettimeofday __gettimeofday50
+#define getrusage __getrusage50
----------------
I expected you remove these too. However looks like we do the same in sanitizer_common_interceptors.inc

 __shmctl50  already defined there. Could you just delete  "#define shmctl __shmctl50" and "DECLARE_REAL(int, shmctl, int shmid, int cmd, void *buf)"
and move "INTERCEPTOR(void *, shmat" to just before "INTERCEPTOR(int, dl_iterate_phdr", after sanitizer_common_interceptors.inc ?




================
Comment at: lib/sanitizer_common/sanitizer_platform_limits_netbsd.h:579
+#define SIGACTION_SYMNAME __sigaction14
+
 #endif  // SANITIZER_NETBSD
----------------
So we don't remove gettimeofday ang getrusage, maybe we could return this back. It's up to you.


Repository:
  rL LLVM

https://reviews.llvm.org/D40766