[PATCH] D40778: [DebugIR] Revive the Debug IR pass. [Added llvm-commits]

[Vedant Kumar via Phabricator via llvm-commits]

vsk added a comment.

In https://reviews.llvm.org/D40778#945621, @bollu wrote:

> Regarding `StripDebugInfo`, I did not know it existed. I should refactor the code to use it, I assume? I'll check this out.


Sounds good.

> About being a pass or not - I don't understand what this sentence means, @vsk :
> 
>> Implementing -debugir in the LL reader has other advantages, e.g it allows you to mark up the LL file with comments or edit it, then re-compile & debug again
> 
> Why would this not work if it were a pass as well? Because the comments would be stripped away in the LLVM module?

Right, unless the line to instruction mapping were somehow recorded into the module. The easiest way to do that is to attach debug info to the IR when it’s parsed.


https://reviews.llvm.org/D40778