[PATCH] D40714: Correct atexit(3) support in MSan/NetBSD

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka added a comment.

lgtm if redundant comments removed
does anyone else have anything to add?



================
Comment at: lib/msan/msan_interceptors.cc:1144
+
+    res = REAL(__cxa_atexit)((void (*)(void *a))MSanAtExitWrapper, 0, 0);
+    // Push AtExitCtx on the top of the stack of callback functions
----------------
krytarowski wrote:
> vitalybuka wrote:
> > do you need to call REAL(__cxa_atexit) under the lock?
> Yes, as I'm pushing an item to the LIFO container.
I see
 there is possibility of MSanAtExitWrapper  immediately after REAL(__cxa_atexit) call
so we don't want want MSanAtExitWrapper pass that mutex before we push



Repository:
  rL LLVM

https://reviews.llvm.org/D40714