[PATCH] D38406: [dump] Remove NDEBUG from test to enable dump methods [NFC]

[Don Hinton via Phabricator via llvm-commits]

hintonda added a comment.

In https://reviews.llvm.org/D38406#945892, @hintonda wrote:

> In https://reviews.llvm.org/D38406#945869, @bogner wrote:
>
> > In https://reviews.llvm.org/D38406#945845, @hintonda wrote:
> >
> > > My solution would support buildbots, developer builds, and installed versions via llvm-config.
> >
> >
> > I don't understand how this version supports installed versions, the define doesn't appear in llvm-config at all here. Can you explain?
>
>
> I was planning on using llvm-config, e.g.:
>
>   local:/Users/dhinton/projects/llvm_project/build/Debug $ bin/llvm-config --cxxflags
>   -I/Users/dhinton/projects/llvm_project/llvm/include -I/Users/dhinton/projects/llvm_project/build/Debug/include  -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -std=c++11 -Wall -W -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wcovered-switch-default -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wstring-conversion -fcolor-diagnostics -O3  -DLLVM_ENABLE_DUMP  -fno-exceptions -fno-rtti -D_DEBUG -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS
>


Btw, this was configured with `cmake -GNinja ../../llvm -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_ASSERTIONS=On` against the current patch.


https://reviews.llvm.org/D38406